Skip to content

8341443: [macos] AppContentTest and SigningOptionsTest failed due to "codesign" does not fails with "--app-content" on macOS 15 #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8341443: [macos] AppContentTest and SigningOptionsTest failed due to "codesign" does not fails with "--app-content" on macOS 15 #2442

wants to merge 1 commit into from

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 4, 2025 •
edited by openjdk bot
Loading

I backport this to simplify backporting "8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions" which reworks this test fix.

Omitted SigningOptionsTest.java which was added by 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild in 22.

Omitted adding @modules to AppContentTest as later change "8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file" was already backported in 21.0.7.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8341443 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341443: [macos] AppContentTest and SigningOptionsTest failed due to "codesign" does not fails with "--app-content" on macOS 15 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2442/head:pull/2442
$ git checkout pull/2442

Update a local copy of the PR:
$ git checkout pull/2442
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2442

View PR using the GUI difftool:
$ git pr show -t 2442

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2442.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 4, 2025 •
edited
Loading

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341443: [macos] AppContentTest and SigningOptionsTest failed due to "codesign" does not fails with "--app-content" on macOS 15

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 85e0e6452d167db2fadd60543f875a6375339604 8341443: [macos] AppContentTest and SigningOptionsTest failed due to "codesign" does not fails with "--app-content" on macOS 15 Nov 4, 2025
@openjdk
Copy link

openjdk bot commented Nov 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 4, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 4, 2025

Webrevs

@openjdk openjdk bot mentioned this pull request Nov 4, 2025
Closed
3 tasks
reinrich
reinrich approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@reinrich reinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport looks good to me.
Cheers, Richard.

@openjdk
Copy link

openjdk bot commented Nov 6, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member Author

GoeLin commented Nov 7, 2025

Thanks for teh review!

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 7, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Nov 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

Going to push as commit 09f2fcf.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 10, 2025
@openjdk openjdk bot closed this Nov 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 10, 2025
@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@GoeLin Pushed as commit 09f2fcf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8341443 branch November 10, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@reinrich reinrich reinrich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GoeLin @reinrich